Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(serializer): fixes #2003 ivy enabled #2016

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix(serializer): fixes #2003 ivy enabled #2016

merged 1 commit into from
Mar 21, 2023

Conversation

rubiesonthesky
Copy link
Contributor

Summary

This attempts to solve issue when ɵivyEnabled was removed from Angular. Put quickly together.

Test plan

I'm not sure does existing tests really test that this will work and not break non-ivy support.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@rubiesonthesky
Copy link
Contributor Author

So what is worth, I cherry-picked locally the commit from here #2001 and run tests and it seemed that there were no errors locally.

ahnpnl
ahnpnl approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and let see if CI passes in Bot PR

@ahnpnl ahnpnl merged commit 44d3922 into thymikee:main Mar 21, 2023
@CSchulz CSchulz mentioned this pull request Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahnpnl ahnpnl ahnpnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubiesonthesky @ahnpnl